Simplify batch_ops()
#1492
Simplify batch_ops()
#1492
Conversation
plafer
added
the
no changelog
There was a problem hiding this comment.
Looks good! Thank you! I left one small comment inline.
I also used
Iterator::flat_mapinstead ofwinter_utils::flatten_slice_elementssince it's more canonical, and doesn't affect performance (blake3 benchmark).
I'm not sure the blake3 benchmark is applicable here. this benchmark is dominated by the prover time, but this change mostly impacts instantiation of basic blocks which happens both during assembly and deserialization. I wonder if the compilation benchmark we have in the stdlib crate is more applicable here.
Ah yes good point. I ran that benchmark, and it is also unchanged. |
Small PR that simplifies
batch_ops()by not returning redundant information (i.e. batch groups).I also used
Iterator::flat_mapinstead ofwinter_utils::flatten_slice_elementssince it's more canonical, and doesn't affect performance (blake3 benchmark). I also wouldn't be surprised if it compiled down to the same code after compiler optimizations.